Display Farcaster identity: nav, comments, story cards

[realproject7]

Summary

• Add FarcasterAvatar component — reusable address → avatar + @username with link to farcaster.com/{username}, falls back to truncated address
• Add useConnectedIdentity hook — resolves connected wallet's FC identity via getFarcasterProfile server action
• Update ConnectWallet — nav bar shows FC avatar + @username when wallet has linked FC account
• Update CommentSection — commenter addresses replaced with FarcasterAvatar
• Update StoryCard — writer addresses replaced with WriterIdentityClient
• All existing behavior preserved: WriterIdentityClient on story pages unchanged

Fixes #255

Test plan

• Nav bar shows FC avatar + @username when connected wallet has linked FC account
• Nav bar falls back to truncated address when no FC account linked
• Comments show FC identity for commenters with linked FC accounts
• Story cards show FC identity for writers
• WriterIdentityClient on story pages still works correctly
• npm run typecheck passes

🤖 Generated with Claude Code

[project7-interns]

APPROVE — with two non-blocking observations.

1. Missing .catch() on server action promises (non-blocking)
Both FarcasterAvatar.tsx:29 and useConnectedIdentity.ts:27 call getFarcasterProfile(address).then(...) without a .catch(). If the server action rejects (e.g., network error to the server), this produces an unhandled promise rejection. The underlying lookupByAddress catches internally, so this is unlikely in practice, but a .catch(() => null) on both would be strictly correct.

2. Brief flash of truncated address (non-blocking)
FarcasterAvatar renders the truncated address immediately while the server action resolves, then swaps to FC identity. This is a standard loading-state tradeoff and acceptable — just noting it in case a skeleton/shimmer is preferred later.

What looks good:

• Clean separation: useConnectedIdentity for the nav bar (tied to useAccount), FarcasterAvatar for arbitrary addresses (comments)
• farcaster.com URL in the link (not warpcast.com) — correct per current branding
• StoryCard correctly reuses existing WriterIdentityClient instead of duplicating
• Cancellation via cancelled flag in both effects prevents state updates after unmount
• Fallback to truncated address is consistent across all three surfaces

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The new Farcaster identity surfaces match the issue scope, but the story-card change introduces invalid nested links and conflicting click targets.

Findings

• [medium] StoryCard wraps the entire card in Next Link, and this PR replaces the plain writer text with WriterIdentityClient, which itself renders an external <a href="https://farcaster.com/...">. That creates an anchor inside an anchor, which is invalid HTML and can break click behavior on the cards.
  • File: src/components/StoryCard.tsx:44
  • Suggestion: Render a non-link variant inside story cards, or make WriterIdentityClient support a non-interactive mode for already-linked containers.

Decision

Request changes. The new identity display is otherwise on the right track, but the nested-anchor regression should be fixed before merge.

[project7-interns]

Verdict: APPROVE

Summary

The follow-up patch fixes the story-card nested-anchor regression by adding a non-link rendering mode for identity components. The Farcaster identity rollout remains aligned with issue #255.

Findings

• [info] No blocking issues found in the updated patch.

Decision

Approve. linkProfile={false} removes the invalid anchor nesting inside story cards while preserving linked identity displays in comments and other standalone contexts. CI was still pending when reviewed.