Open
Conversation
MatanP12
added
documentation
MatanP12
requested review from
AlonShakaroff,
OmerCS8,
TomerNewmanPrograms and
yulisuliman
TomerNewmanPrograms
requested changes
Apr 10, 2022
OmerCS8
previously approved these changes
Apr 10, 2022
Collaborator
OmerCS8
left a comment
OmerCS8
left a comment
There was a problem hiding this comment.
LGTM nice work!
Maybe change the label to 'backlog' as it is not at top priority to the demo 😉.
Contributor
|
Is there an issue linked to this PR? |
Open
Collaborator
Collaborator
Author
yulisuliman
previously approved these changes
Apr 12, 2022
abiton1
reviewed
Apr 18, 2022
yulisuliman
previously approved these changes
Apr 24, 2022
TomerNewmanPrograms
previously approved these changes
Apr 27, 2022
natifridman
requested changes
Apr 27, 2022
MatanP12
dismissed stale reviews from TomerNewmanPrograms and yulisuliman
via
1d82df6
yulisuliman
previously approved these changes
Apr 29, 2022
natifridman
previously approved these changes
May 25, 2022
Adding checklist to fill when commiting.
MatanP12
dismissed stale reviews from natifridman, abiton1, and yulisuliman
via
29ed17f
natifridman
approved these changes
May 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a checklist I built from previous PRs code reviews.
@AlonShakaroff @yulisuliman @TomerNewmanPrograms @OmerCS8 Please tell me if there are more common things I should add 🙂
fix #90