Skip to content

feat: APP-836 ledger v7 upgrade#2772

Merged
blushi merged 7 commits intodevfrom
feat-APP-836-ledger-v7
Dec 31, 2025
Merged

feat: APP-836 ledger v7 upgrade#2772
blushi merged 7 commits intodevfrom
feat-APP-836-ledger-v7

Conversation

@blushi
Copy link
Copy Markdown
Member

@blushi blushi commented Dec 11, 2025

Description

PR on regen-js for proto related changes: regen-network/regen-js#94
I have already tagged a new release to speed things up that I use in this PR.

https://regennetwork.atlassian.net/browse/APP-836
Also fixes some issues creating credit batches and on chain projects https://regennetwork.atlassian.net/browse/APP-846 and https://regennetwork.atlassian.net/browse/APP-843, we were relying on rawLog within the deliverTxResponse to get new project/batch id but rawLog is now deprecated > cosmos-sdk 0.50 and is empty, now using events instead.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Check on chain projects and correct credit prices appear on /projects and in some project buy flow
  2. Create an on chain project and click to see the new project page
  3. Create a credit batch and check the credit batch id
  4. Create a data post, without signing it and signing it, double check that the anchor/attest events appear in the timeline of the data post page

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link
Copy Markdown

netlify bot commented Dec 11, 2025

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 1c0fff7
🔍 Latest deploy log https://app.netlify.com/projects/terrasos/deploys/6955401fedc62e000880a471
😎 Deploy Preview https://deploy-preview-2772--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 11, 2025

@erikalogie @S4mmyb see testing instructions

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 11, 2025

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@alexander-astrand alexander-astrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@S4mmyb
Copy link
Copy Markdown
Member

S4mmyb commented Dec 16, 2025

@blushi , one of the accounts I'm testing on is an issuer for USS01 (addr regen1g639urqp3qt8n9670lc60mnpdrxfap499mexdl), but the create batch and project buttons aren't showing up. Should those be handled in this PR?

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 16, 2025

@blushi , one of the accounts I'm testing on is an issuer for USS01 (addr regen1g639urqp3qt8n9670lc60mnpdrxfap499mexdl), but the create batch and project buttons aren't showing up. Should those be handled in this PR?

as discussed in our 1-1, there were some issues with the indexer last week related to the upgrade, so you can try to remove the issuer and add it back

@erikalogie
Copy link
Copy Markdown
Collaborator

I got this trying to create a credit batch
image

@erikalogie
Copy link
Copy Markdown
Collaborator

Got this error when signing a post
image

post url: https://deploy-preview-2772--regen-marketplace.netlify.app/post/regen:13toVgC2JXDpCueL2Br5fkVb7PUBpsDWmQmXt5ocUSp6Z68U91qDgZt.rdf

It works without signing

@erikalogie
Copy link
Copy Markdown
Collaborator

Timeline events take a long time to load on the post without signing that I was able to create

@erikalogie
Copy link
Copy Markdown
Collaborator

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 17, 2025

Got this error when signing a post image

post url: https://deploy-preview-2772--regen-marketplace.netlify.app/post/regen:13toVgC2JXDpCueL2Br5fkVb7PUBpsDWmQmXt5ocUSp6Z68U91qDgZt.rdf

It works without signing

this is because you're using an old DAO where members were not allowed to sign data yet OR a DAO created through some other open PR with new permissions settings (hence the error "Message not allowed by filter...", Same for the create batch error.
Since I had to update DAO permissions in multiple PRs, I would advise to always create a new DAO from the specific deploy preview when testing ongoing PRs (and name it after the PR number for instance), just to be sure you're not running into those types of issues. cc/ @S4mmyb I know this is cumbersome but I do not see any other option. At least, we'll catch any regression in the create org flow... Let me know if you want me to remove you from those old DAOs so you can create new ones, without having to set up a new wallet in Keplr

@blushi blushi force-pushed the feat-APP-836-ledger-v7 branch from d5eb2d6 to d05a911 Compare December 17, 2025 08:15
@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 17, 2025

Timeline events take a long time to load on the post without signing that I was able to create

Yes I know, this is because now we need to search for other types of msgs (since signing can be done through cosmwasm too now) so the query takes longer, especially when there's no signing event since we need to go through all potential events. Ideally, we would index signatures in our indexer to improve speed, I can create a follow-up issue and let's discuss prioritization with @S4mmyb

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 17, 2025

https://www.loom.com/share/3b9fa75fd1be41349fb69394b43af187?from_recorder=1&focus_title=1

this works for me, could you open the dev tools console and see if any error gets displayed there as soon as you hit the next button, you can also look up for any errors in the network tab, if there's a request (possibly in red) appearing as soon as you hit the next button, share the "payload" and "preview" tabs for this request

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 26, 2025

Got this error when signing a post image
post url: https://deploy-preview-2772--regen-marketplace.netlify.app/post/regen:13toVgC2JXDpCueL2Br5fkVb7PUBpsDWmQmXt5ocUSp6Z68U91qDgZt.rdf
It works without signing

this is because you're using an old DAO where members were not allowed to sign data yet OR a DAO created through some other open PR with new permissions settings (hence the error "Message not allowed by filter...", Same for the create batch error. Since I had to update DAO permissions in multiple PRs, I would advise to always create a new DAO from the specific deploy preview when testing ongoing PRs (and name it after the PR number for instance), just to be sure you're not running into those types of issues. cc/ @S4mmyb I know this is cumbersome but I do not see any other option. At least, we'll catch any regression in the create org flow... Let me know if you want me to remove you from those old DAOs so you can create new ones, without having to set up a new wallet in Keplr

BTW in order to test this, you do not actually necessarily need to do it through a DAO @erikalogie @S4mmyb

@S4mmyb
Copy link
Copy Markdown
Member

S4mmyb commented Dec 29, 2025

Great, all of this worked for me!

@blushi
Copy link
Copy Markdown
Member Author

blushi commented Dec 31, 2025

Timeline events take a long time to load on the post without signing that I was able to create

Yes I know, this is because now we need to search for other types of msgs (since signing can be done through cosmwasm too now) so the query takes longer, especially when there's no signing event since we need to go through all potential events. Ideally, we would index signatures in our indexer to improve speed, I can create a follow-up issue and let's discuss prioritization with @S4mmyb

That's the follow up issue https://regennetwork.atlassian.net/browse/APP-852
in the mean time, I've improved the UI a bit so it displays at least the creation event (which we have already) with some loading skeleton for the tx hash, the signing events will only appear when loading is done (small loading spinner next to "Timeline")

image

@blushi blushi merged commit 9409c37 into dev Dec 31, 2025
14 checks passed
@blushi blushi deleted the feat-APP-836-ledger-v7 branch December 31, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants