Simultaneously forecast state and hsa locations in a single call#20
Merged
lshandross merged 7 commits intomainfrom Jan 7, 2026
Merged
Conversation
…hsas Construct a new "unique_id" column that concatenates aggregation level and location code (fips code for states and hsa nci id for hsas) so that disparate locations with the same location code can still be forecast, then keep "agg_level" column in returned forecasts
- Remove tests for error when simultaneously forecasting state and hsas - Update test for forecasting only states using NSSP data to reduce locations - Add test for simultaneously forecasting state and hsas using NSSP data
nickreich
reviewed
Dec 19, 2025
Member
nickreich
left a comment
nickreich
left a comment
There was a problem hiding this comment.
I have some questions/comments about generalizability around the agg_level and unique_id variables.
Also update associated test data
nickreich
previously approved these changes
Jan 7, 2026
Member
nickreich
left a comment
nickreich
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the changes! I reviewed the latest commits since my last review.
nickreich
approved these changes
Jan 7, 2026
Member
nickreich
left a comment
nickreich
left a comment
There was a problem hiding this comment.
thanks for remembering the version number!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes for this PR are broken down into 3 categories:
Update SARIX and GBQR to allow simultaneous forecasting of state and hsas
Update SARIX and GBQR tests
Update test data
Once this is approved, I'll increment the version to 1.2.0 to indicate a minor patch release