replace SimpleNamespace configs with typed dataclasses and enums#43
replace SimpleNamespace configs with typed dataclasses and enums#43matthewcornell wants to merge 3 commits intomainfrom
Conversation
… idmodels.config across all Python models. Update idmodels to de6be08. Switch Python dependency management from ad-hoc requirements.txt to pip-compile workflow with requirements.in source files; pin Python 3.12 via .python-version. Update README to document the new pip-tools workflow.
lshandross
left a comment
There was a problem hiding this comment.
The changes themselves LGTM, but I was wondering when you were planning to rebuild the docker containers and if we should wait to do so until after forecasts are submitted for this week so we have time to try running the new version before we submit the next round of forecasts.
@lshandross Great question. I was planning on asking everyone's opinion re: when to deploy the changes. I've tested them locally - both direct |
|
I'm fine with the current plan of delaying (since that's what we did when there were changes in the pipeline before), but we can also discuss during our meeting about both PRs |
|
Thanks for your comments @lshandross and @trobacker . Here's what I distilled from them: PLAN:
[new via Nick's comment]:
|
…Config, moving instance variables to corresponding *ModelConfig classes. made RunConfig concrete
|
I've updated the code to match requested idmodels changes. Please review 4c01eac . |
This PR is part of Operational models refactoring ideas #42. It is paired with the idmodels PR [replace SimpleNamespace configs with typed dataclasses and enums #24].
Changes: