This repository was archived by the owner on Jan 11, 2022. It is now read-only.
Improve scroll performance on Safari macOS#68
Open
Kukiwon wants to merge 6 commits intorgalus:masterfrom
Open
Conversation
SassNinja
added a commit
to SassNinja/sticky-js
that referenced
this pull request
Jul 9, 2020
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current setup, when the data-sticky-wrap option is used, the scroll performance on Safari (13.0.5) on macOS (10.15.3) is not good. This PR adds a change that the code that updates the position of the sticky element in a requestAnimationFrame callback.
This results in smooth scroll performance on Safari.