Fix Hardcoded localhost URLs#11
Conversation
8c42f9e to
27c6f8f
Compare
There was a problem hiding this comment.
I'd like the s/uri/command/ change to be reverted unless you can show that ansible.builtin.uri actually runs from the controller as claimed.
After investigating this issue manually in the live environment, I believe the only meaningful change is s/localhost/127.0.0.1/ due to localhost resolving to ::1 and vllm only listening on IPV4.
Thanks for finding that!
| # [string] Additional environment variables | ||
| gpu_validation_workload_additional_env: "--env=HF_HUB_OFFLINE=0 --env=VLLM_NO_USAGE_STATS=1" | ||
| # [string] vLLM API URL | ||
| gpu_validation_vllm_api_url: "http://127.0.0.1:8000" |
| ansible.builtin.uri: | ||
| url: http://localhost:8000/health | ||
| - name: Wait for vllm API to appear # noqa: command-instead-of-module | ||
| # Use curl command instead of uri module because uri runs on the controller, |
There was a problem hiding this comment.
AFAICT This is not true, so I do not approve of this change from ansible.builtin.uri to ansible.builtin.command
Using the new variable is fine.
There was a problem hiding this comment.
both will run on the same target host.
If you want another host, you should have it in the inventory, and use delegate_to
There was a problem hiding this comment.
| - name: Wait for vllm metrics endpoint to appear | ||
| ansible.builtin.uri: | ||
| url: http://localhost:8000/metrics/ | ||
| - name: Wait for vllm metrics endpoint to appear # noqa: command-instead-of-module |
27c6f8f to
869a24b
Compare
869a24b to
761cae7
Compare
What does this PR do?
Fix Hardcoded localhost URLs (IPv6/IPv4 Problem).
Why do we need this PR?
The playbook had hardcoded URLs scattered across multiple files using http://localhost:8000, which caused the following problems:
I added a new centralized variable
gpu_validation_vllm_api_url