Skip to content

Fix Hardcoded localhost URLs #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MiguelCarpio merged 1 commit into from
Jan 15, 2026
Merged

Fix Hardcoded localhost URLs #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gpu-validation/defaults/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,3 +75,5 @@ gpu_validation_workload_userns: # "--userns=keep-id:uid=1001" for RHAIIS
gpu_validation_workload_shm_size: "--shm-size=4g"
# [string] Additional environment variables
gpu_validation_workload_additional_env: "--env=HF_HUB_OFFLINE=0 --env=VLLM_NO_USAGE_STATS=1"
# [string] vLLM API URL
gpu_validation_vllm_api_url: "http://127.0.0.1:8000"
Copy link
Contributor

@csibbitt csibbitt Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

4 changes: 2 additions & 2 deletions gpu-validation/tasks/model_download_and_serve.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@

- name: Wait for vllm API to appear
ansible.builtin.uri:
url: http://localhost:8000/health
url: "{{ gpu_validation_vllm_api_url }}/health"
register: api_result
until: ("status" in api_result) and (api_result.status == 200)
retries: 180 # 180 * 10 = 30 mins - this includes the time to download the model
Expand All @@ -66,7 +66,7 @@

- name: Wait for vllm metrics endpoint to appear
ansible.builtin.uri:
url: http://localhost:8000/metrics/
url: "{{ gpu_validation_vllm_api_url }}/metrics/"
register: metrics_result
until: ("status" in metrics_result) and (metrics_result.status == 200)
retries: 12 # 12 * 10 = 2 mins after API appears
Expand Down
1 change: 1 addition & 0 deletions gpu-validation/tasks/model_performance.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
- name: Run the model performance check script
ansible.builtin.command: /tmp/scripts/model_performance_check.sh
environment:
URL: "{{ gpu_validation_vllm_api_url }}"
MODEL_NAME: "{{ gpu_validation_model_name }}"
register: performance_script_output
changed_when: false
Expand Down