Skip to content

Upgrade version to 1.2.0#102

Open
ricky9667 wants to merge 11 commits intomasterfrom
release/1.2.0
Open

Upgrade version to 1.2.0#102
ricky9667 wants to merge 11 commits intomasterfrom
release/1.2.0

Conversation

@ricky9667
Copy link
Owner

Summary

Briefly explain the problem and what this PR changes.

  • Problem: As title.
  • Solution: As title.
  • Type: [ ] Feature [ ] Bugfix [ ] Refactor [x] Chore [ ] Docs

Context / Links

  • Issue(s): Closes #
  • Design / spec / ticket:
  • Related PRs:

Implementation details

Highlight important decisions, trade-offs, or tricky parts of the code.

Screenshots / API changes (if applicable)

  • UI: before / after, or key screenshots.
  • API: new/changed endpoints, payloads, or contracts.

Testing

Describe how this was tested and what scenarios were covered.

  • Unit tests
  • Integration / e2e tests
  • Manual tests

Steps / commands:

@ricky9667 ricky9667 added this to the v1.2 milestone Feb 9, 2026
@ricky9667 ricky9667 self-assigned this Feb 9, 2026
@ricky9667 ricky9667 added the feature New feature or request label Feb 9, 2026
Copilot AI review requested due to automatic review settings February 9, 2026 07:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the application release versioning across Gradle + iOS config, and records the 1.2.0 release notes in the in-app changelog.

Changes:

  • Bump app version to 1.2.0 and build number to 6 (Gradle + iOS xcconfig).
  • Add a 1.2.0 entry to the in-app changelog data.
  • Update material-kolor dependency version to 4.1.1.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
iosApp/iosApp.xcodeproj/project.pbxproj Updates iOS build settings (incl. code signing team).
iosApp/Versions.xcconfig Updates iOS marketing/build versions to 1.2.0 / 6.
gradle/libs.versions.toml Bumps material-kolor from 4.1.0 to 4.1.1.
gradle.properties Bumps appVersionName/appBuildNumber to 1.2.0 / 6.
composeApp/src/jvmMain/.../AppVersionImpl.jvm.kt Updates hardcoded JVM/desktop version name and signature.
composeApp/src/commonMain/.../ChangelogData.kt Adds 1.2.0 changelog entries.
Comments suppressed due to low confidence (1)

composeApp/src/jvmMain/kotlin/com/rickyhu/hushtimer/core/domain/AppVersionImpl.jvm.kt:13

  • getVersionCode() still returns 5, but the build number was bumped to 6 in gradle.properties (and iOS CURRENT_PROJECT_VERSION too). This can cause inconsistent version reporting across platforms; update this to match the new build number, and adjust the NOTE (it references Android config but this is the JVM/desktop implementation).
    override fun getVersionCode(): Int {
        // NOTE: Update this when changing versionCode in build.gradle.kts android configuration
        return 5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +6 to 9
override fun getVersionName(): Version {
// NOTE: Update this when changing packageVersion in build.gradle.kts desktop configuration
return Version(1, 0, 4)
return Version(1, 2, 0)
}
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The desktop/JVM app version is hardcoded here, but the Gradle desktop distribution packageVersion (see composeApp/build.gradle.kts) is still on an older value. To keep update checks and distributed artifact metadata consistent, bump the desktop packageVersion alongside this change or source this value from a single build-time constant.

Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Xanonymous-GitHub
Copy link
Collaborator

@ricky9667 I think we can also update this ver value ?

packageVersion = "1.0.3"

@ricky9667
Copy link
Owner Author

@copilot make these 2 changes

  1. Change packageVersion = "1.0.3" to packageVersion = "1.2.0" in composeApp build.gradle.kts
  2. Change AppVersionImpl.jvm.kt getVersionCode() return value to 6.

Copy link
Contributor

Copilot AI commented Feb 10, 2026

@ricky9667 I've opened a new pull request, #103, to work on those changes. Once the pull request is ready, I'll request review from you.

@ricky9667
Copy link
Owner Author

@copilot I found out that when I generate a signed release app bundle for Android (:composeApp:bundleRelease), the app Test environment ConfigCat SDK key instead of Production environment SDK key. Please help me review composeApp build.gradle.kts and check the usage of BuildKonfig and fix this problem. Also help me find an approach to test if this problem is solved.

Copy link
Contributor

Copilot AI commented Feb 15, 2026

@ricky9667 I've opened a new pull request, #105, to work on those changes. Once the pull request is ready, I'll request review from you.

@Xanonymous-GitHub
Copy link
Collaborator

@ricky9667 bro is so sigma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants