Conversation
There was a problem hiding this comment.
Pull request overview
Updates the application release versioning across Gradle + iOS config, and records the 1.2.0 release notes in the in-app changelog.
Changes:
- Bump app version to 1.2.0 and build number to 6 (Gradle + iOS xcconfig).
- Add a 1.2.0 entry to the in-app changelog data.
- Update
material-kolordependency version to 4.1.1.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| iosApp/iosApp.xcodeproj/project.pbxproj | Updates iOS build settings (incl. code signing team). |
| iosApp/Versions.xcconfig | Updates iOS marketing/build versions to 1.2.0 / 6. |
| gradle/libs.versions.toml | Bumps material-kolor from 4.1.0 to 4.1.1. |
| gradle.properties | Bumps appVersionName/appBuildNumber to 1.2.0 / 6. |
| composeApp/src/jvmMain/.../AppVersionImpl.jvm.kt | Updates hardcoded JVM/desktop version name and signature. |
| composeApp/src/commonMain/.../ChangelogData.kt | Adds 1.2.0 changelog entries. |
Comments suppressed due to low confidence (1)
composeApp/src/jvmMain/kotlin/com/rickyhu/hushtimer/core/domain/AppVersionImpl.jvm.kt:13
getVersionCode()still returns5, but the build number was bumped to6ingradle.properties(and iOSCURRENT_PROJECT_VERSIONtoo). This can cause inconsistent version reporting across platforms; update this to match the new build number, and adjust the NOTE (it references Android config but this is the JVM/desktop implementation).
override fun getVersionCode(): Int {
// NOTE: Update this when changing versionCode in build.gradle.kts android configuration
return 5
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| override fun getVersionName(): Version { | ||
| // NOTE: Update this when changing packageVersion in build.gradle.kts desktop configuration | ||
| return Version(1, 0, 4) | ||
| return Version(1, 2, 0) | ||
| } |
There was a problem hiding this comment.
The desktop/JVM app version is hardcoded here, but the Gradle desktop distribution packageVersion (see composeApp/build.gradle.kts) is still on an older value. To keep update checks and distributed artifact metadata consistent, bump the desktop packageVersion alongside this change or source this value from a single build-time constant.
composeApp/src/commonMain/kotlin/com/rickyhu/hushtimer/core/domain/ChangelogData.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@ricky9667 I think we can also update this ver value ? HushTimer/composeApp/build.gradle.kts Line 192 in a03eba8 |
|
@copilot make these 2 changes
|
|
@ricky9667 I've opened a new pull request, #103, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>
|
@copilot I found out that when I generate a signed release app bundle for Android ( |
|
@ricky9667 I've opened a new pull request, #105, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@ricky9667 bro is so sigma |
Summary
Briefly explain the problem and what this PR changes.
Context / Links
Implementation details
Highlight important decisions, trade-offs, or tricky parts of the code.
Screenshots / API changes (if applicable)
Testing
Describe how this was tested and what scenarios were covered.
Steps / commands: