Skip to content

chore: sync desktop package version and version code to 1.2.0#103

Merged
ricky9667 merged 2 commits intorelease/1.2.0from
copilot/sub-pr-102
Feb 10, 2026
Merged

chore: sync desktop package version and version code to 1.2.0#103
ricky9667 merged 2 commits intorelease/1.2.0from
copilot/sub-pr-102

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

Summary

Briefly explain the problem and what this PR changes.

  • Problem: Desktop package version (1.0.3) and JVM version code (5) were out of sync with the 1.2.0 release.
  • Solution: Update desktop packageVersion to 1.2.0 and JVM getVersionCode() to 6.
  • Type: [ ] Feature [ ] Bugfix [ ] Refactor [x] Chore [ ] Docs

Context / Links

  • Design / spec / ticket:
  • Related PRs:

Implementation details

  • composeApp/build.gradle.kts: Bumped desktop distribution packageVersion from "1.0.3" to "1.2.0"
  • AppVersionImpl.jvm.kt: Updated getVersionCode() return value from 5 to 6

Ensures distributed artifact metadata and runtime version checks align with the 1.2.0 release across all platforms.

Screenshots / API changes (if applicable)

  • UI: before / after, or key screenshots.
  • API: new/changed endpoints, payloads, or contracts.

Testing

Describe how this was tested and what scenarios were covered.

  • Unit tests
  • Integration / e2e tests
  • Manual tests

Steps / commands:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 10, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -Xmx4G -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en -Duser.variant (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Upgrade version to 1.2.0 chore: sync desktop package version and version code to 1.2.0 Feb 10, 2026
Copilot AI requested a review from ricky9667 February 10, 2026 01:08
@ricky9667 ricky9667 marked this pull request as ready for review February 10, 2026 01:09
Copilot AI review requested due to automatic review settings February 10, 2026 01:09
@ricky9667 ricky9667 merged commit 16d23bb into release/1.2.0 Feb 10, 2026
@ricky9667 ricky9667 deleted the copilot/sub-pr-102 branch February 10, 2026 01:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates desktop distribution metadata and the JVM runtime version code so app artifacts and version checks align with the 1.2.0 release.

Changes:

  • Bumped Compose Desktop packageVersion to 1.2.0.
  • Updated JVM AppVersionImpl.getVersionCode() from 5 to 6.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
composeApp/build.gradle.kts Updates desktop native distribution packageVersion for the 1.2.0 release.
composeApp/src/jvmMain/kotlin/com/rickyhu/hushtimer/core/domain/AppVersionImpl.jvm.kt Aligns JVM version code used by runtime/version-check logic with the current build number.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
packageName = "Hush Timer"
packageVersion = "1.0.3"
packageVersion = "1.2.0"
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packageVersion is hard-coded even though this build script already reads appVersionName from gradle.properties. To avoid future version drift (the issue this PR fixes), set packageVersion from appVersionName (or a single shared version constant) rather than duplicating the string literal here.

Suggested change
packageVersion = "1.2.0"
packageVersion = appVersionName

Copilot uses AI. Check for mistakes.
Comment on lines 11 to +13
override fun getVersionCode(): Int {
// NOTE: Update this when changing versionCode in build.gradle.kts android configuration
return 5
return 6
Copy link

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getVersionCode() is still a manually-updated constant, which can drift from the Gradle appBuildNumber/Android versionCode again. Consider sourcing this from a generated build-time constant (e.g., via BuildKonfig) so JVM/Desktop version checks always reflect the build configuration without needing a code change.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants