chore: sync desktop package version and version code to 1.2.0#103
chore: sync desktop package version and version code to 1.2.0#103ricky9667 merged 2 commits intorelease/1.2.0from
Conversation
Co-authored-by: ricky9667 <55730003+ricky9667@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Updates desktop distribution metadata and the JVM runtime version code so app artifacts and version checks align with the 1.2.0 release.
Changes:
- Bumped Compose Desktop
packageVersionto1.2.0. - Updated JVM
AppVersionImpl.getVersionCode()from5to6.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| composeApp/build.gradle.kts | Updates desktop native distribution packageVersion for the 1.2.0 release. |
| composeApp/src/jvmMain/kotlin/com/rickyhu/hushtimer/core/domain/AppVersionImpl.jvm.kt | Aligns JVM version code used by runtime/version-check logic with the current build number. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb) | ||
| packageName = "Hush Timer" | ||
| packageVersion = "1.0.3" | ||
| packageVersion = "1.2.0" |
There was a problem hiding this comment.
packageVersion is hard-coded even though this build script already reads appVersionName from gradle.properties. To avoid future version drift (the issue this PR fixes), set packageVersion from appVersionName (or a single shared version constant) rather than duplicating the string literal here.
| packageVersion = "1.2.0" | |
| packageVersion = appVersionName |
| override fun getVersionCode(): Int { | ||
| // NOTE: Update this when changing versionCode in build.gradle.kts android configuration | ||
| return 5 | ||
| return 6 |
There was a problem hiding this comment.
getVersionCode() is still a manually-updated constant, which can drift from the Gradle appBuildNumber/Android versionCode again. Consider sourcing this from a generated build-time constant (e.g., via BuildKonfig) so JVM/Desktop version checks always reflect the build configuration without needing a code change.
Summary
Briefly explain the problem and what this PR changes.
packageVersionto 1.2.0 and JVMgetVersionCode()to 6.Context / Links
Implementation details
composeApp/build.gradle.kts: Bumped desktop distributionpackageVersionfrom "1.0.3" to "1.2.0"AppVersionImpl.jvm.kt: UpdatedgetVersionCode()return value from 5 to 6Ensures distributed artifact metadata and runtime version checks align with the 1.2.0 release across all platforms.
Screenshots / API changes (if applicable)
Testing
Describe how this was tested and what scenarios were covered.
Steps / commands:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.