fix: Fix issue with require-file-for-ns#9
Open
rynkowsg wants to merge 1 commit intorobertluo:mainfrom
Open
Conversation
I found out that for some namespace symbols the require-file-for-ns doesn't work. The file path received from ns meta is not absolute, but relative to the src directory. Therefore io/file could not resolve the file (isFile false). ``` (require-file-for-ns 'chargedup.stations-api-authorizer.handler) Execution error (ExceptionInfo) at com.mjdowney.rich-comment-tests/require-file-for-ns (rich_comment_tests.clj:206). Failed to resolve source file for ns chargedup.stations-api-authorizer.handler ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found out that for some namespace symbols the require-file-for-ns doesn't work.
The file path received from ns meta is not absolute, but relative to the src directory.
Therefore io/file could not resolve the file (isFile false).