Skip to content

fix: Fix issue with require-file-for-ns #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rynkowsg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fix issue with require-file-for-ns #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/com/mjdowney/rich_comment_tests.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,13 +199,26 @@
vals
(keep (comp :file meta))
first)]
(let [nsf (io/file ns-file-from-metadata)]
;; Yet another hack: Sometimes the path taken from meta is not a full path.
;; If so, process it as a resource and resolve the full path that way.
(let [full-path (if (string/starts-with? ns-file-from-metadata (System/getProperty "user.home"))
ns-file-from-metadata
(io/resource ns-file-from-metadata))
nsf (io/file full-path)]
(when (.isFile nsf)
(.getPath nsf))))
(throw
(ex-info (str "Failed to resolve source file for ns " ns)
{:ns ns}))))

^:rct/test
(comment
(require-file-for-ns *ns*) ;=> string?
(require-file-for-ns 'com.mjdowney.rich-comment-tests) ;=> string?
(require 'com.mjdowney.rich-comment-tests.impl)
(require-file-for-ns 'com.mjdowney.rich-comment-tests.impl) ;=> string?
#_:rct/test)

(defn run-ns-tests!
"Take a namespace or namespace symbol, attempt to find the corresponding
source file, and run tests in the namespace."
Expand Down