refactor(actions): standardize action tools, add integration tests (step5)#321
Open
stex2005 wants to merge 2 commits intofeature/step4from
Open
refactor(actions): standardize action tools, add integration tests (step5)#321stex2005 wants to merge 2 commits intofeature/step4from
stex2005 wants to merge 2 commits intofeature/step4from
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 5 of 7 — targets
feature/step4(#316)/rosapi/strings inactions.pytorosapi_service()/rosapi_type()_check_response/_safe_get_values)action_type_map, triplicated typedef parsingturtle_actionlibto ROS 1 Docker images for action server testingget_actions,get_action_details,get_action_statusacross all distrosChanges
ros_mcp/tools/actions.py— refactor + migrate (+188 -477):_parse_typedef()and_fetch_action_part()helpersget_actions: use_check_response/_safe_get_valuesdirectlyget_action_details: require explicitaction_type, return available types when missingsend_action_goal: removeasyncio.sleepthat caused missed resultsasyncioimporttests/integration/test_actions.py— 7 tests:get_actions: returns actions, includes expected action (distro-aware)get_action_details: structure on ROS 2, empty/nonexistent errorsget_action_status: status on ROS 2, empty errorDockerfile.ros1-melodic/noetic— addturtle-actionlibpackageros1_launch.launch— add/turtle_shapeaction server nodeTesting
68 tests pass on humble/jazzy, 66 pass + 2 skipped on melodic/noetic. Skips: action detail inspection and status require ROS 2 rosbridge features (see #320).
Related issues
action_type_map(done in this PR)send_action_goaltimeout bug (websocket manager, out of scope)PR stack