[RF][HF] Don't rely on transient globalObservables set in combinations
#20451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `globalObservables` set is only a temporary set in the proto workspace to accumulate the global observables for the final model config of a channel. By using the global observables from the channel model configs, the `MakeCombinedModel` version that combines channel workspaces can also be run on persistent HistFactory output workspaces, and not only the proto workspaces creates during the parsing of the `Measurement` object.
Test Results 22 files 22 suites 3d 19h 41m 35s ⏱️ For more details on these failures, see this check. Results for commit e0ac188. |
lmoneta
approved these changes
Nov 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
globalObservablesset is only a temporary set in the proto workspace to accumulate the global observables for the final model config of a channel.By using the global observables from the channel model configs, the
MakeCombinedModelversion that combines channel workspaces can also be run on persistent HistFactory output workspaces, and not only the proto workspaces creates during the parsing of theMeasurementobject.@TomasDado