Skip to content

[RF][HF] Don't rely on transient globalObservables set in combinations #20451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
+3 −5
Merged

[RF][HF] Don't rely on transient globalObservables set in combinations #20451

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions roofit/histfactory/src/HistoToWorkspaceFactoryFast.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,11 @@
#include <RooGlobalFunc.h>
#include <RooHelpers.h>
#include <RooHistFunc.h>
#include <RooMultiVarGaussian.h>
#include <RooNumIntConfig.h>
#include <RooPoisson.h>
#include <RooPolyVar.h>
#include <RooProdPdf.h>
#include <RooProduct.h>
#include <RooProfileLL.h>
#include <RooRandom.h>
#include <RooRealSumPdf.h>
#include <RooRealVar.h>
Expand All @@ -56,8 +54,6 @@

#include "TH1.h"
#include "TStopwatch.h"
#include "TVectorD.h"
#include "TMatrixDSym.h"

// specific to this package
#include <RooStats/HistFactory/Detail/HistFactoryImpl.h>
Expand Down Expand Up @@ -1515,7 +1511,9 @@ RooArgList HistoToWorkspaceFactoryFast::createObservables(const TH1 *hist, RooWo
if(!model) std::cout <<"failed to find model for channel"<< std::endl;
// std::cout << "int = " << model->createIntegral(*obsN)->getVal() << std::endl;
models.push_back(model);
globalObs.add(*ch->set("globalObservables"), /*silent=*/true); // silent because observables might exist in other channel.
auto &modelConfig = *static_cast<ModelConfig *>(chs[i]->obj("ModelConfig"));
// silent because observables might exist in other channel:
globalObs.add(*modelConfig.GetGlobalObservables(), /*silent=*/true);

// constrainedParams->add( * ch->set("constrainedParams") );
pdfMap[channel_name]=model;
Expand Down
Loading