-
Couldn't load subscription status.
- Fork 18
Refactor and extend tests #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #210 +/- ##
==========================================
+ Coverage 86.64% 88.19% +1.55%
==========================================
Files 4 4
Lines 277 305 +28
Branches 60 53 -7
==========================================
+ Hits 240 269 +29
Misses 21 21
+ Partials 16 15 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors and extends the test suite for the KDL kinematics interface by adding new test cases, improving test readability with custom matchers, and enhancing error messages. The changes prepare for future test templating across implementations.
Key changes:
- Added custom GoogleTest matchers (
MatrixNear,DoubleNear) to replace manual element-by-element comparisons - Added new test cases for reduced kinematic models (testing both reduced tip and base configurations)
- Improved error logging by adding RCLCPP_ERROR messages for verification failures and enhancing existing error message formatting
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp | Refactored test helper methods to accept parameters, added new test cases for reduced models and frame difference calculations, replaced manual assertions with custom matchers |
| kinematics_interface_kdl/src/kinematics_interface_kdl.cpp | Added detailed error logging for input verification failures, improved error message formatting with quotes, fixed logic for empty base parameter handling |
| kinematics_interface/include/kinematics_interface/kinematics_interface.hpp | Added cross-platform FUNCTION_SIGNATURE macro and Vector6d type alias for improved code reusability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
kinematics_interface_kdl/test/test_kinematics_interface_kdl.cpp
Outdated
Show resolved
Hide resolved
set explicit size for reference output methods error: cannot bind non-const lvalue reference of type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
For #199 I wrote new tests, which are also applicable for KDL.
For easier review:
In a first step, I propose to add the new testcases to the old file. As an upcoming step, I'd use a templated test file to be used by all implementations.