Skip to content

Conversation

@eholum-nasa
Copy link
Collaborator

@eholum-nasa eholum-nasa commented Dec 3, 2025

Mostly non-functional change to consolidate the test resources into a single URDF and launch file. Now you can launch one or the other VIA launch arg, as noted in the readme:

# Brings up the hardware drivers and mujoco interface, along with a single position controller
ros2 launch mujoco_ros2_simulation test_robot.launch.py

# Or optionally include the PID controller as mentioned above
ros2 launch mujoco_ros2_simulation test_robot.launch.py use_pid:=true

While I'm adding reformatting some things and adjusted the link masses to 1 kg.

I was going to consolidate the MJCFs but they were generated from our old tool, so won't poke at those just yet... ideally when we update the converter the difference should just be in which input file to include.

Am background working on some basic tests so wanted to use a single URDF for that.

@eholum-nasa eholum-nasa self-assigned this Dec 3, 2025
@eholum-nasa eholum-nasa requested a review from saikishor December 3, 2025 22:37
@eholum-nasa eholum-nasa force-pushed the consolidate-test-examples branch from d8c2fc3 to 27065d3 Compare December 3, 2025 22:48
@eholum-nasa
Copy link
Collaborator Author

Sorry, I was thinking about updating the pixi lock file while I was at it but maybe I'll do that in #9 once the robostack snapshot is rebuilt.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

eholum-nasa and others added 2 commits December 4, 2025 09:41
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
@eholum-nasa eholum-nasa merged commit 040657b into jazzy-devel Dec 4, 2025
5 checks passed
@eholum-nasa eholum-nasa deleted the consolidate-test-examples branch December 4, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants