Skip to content

Conversation

@saikishor
Copy link
Member

No description provided.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we change the error string of export_reference_interfaces for clarifying #2722 similarily?

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks good

here's a provocative question: can't we avoid this warning altogether and do the reallocation of capacity? but we cannot really because we don't know where it was called from?

@christophfroehlich
Copy link
Contributor

thanks, this looks good

here's a provocative question: can't we avoid this warning altogether and do the reallocation of capacity? but we cannot really because we don't know where it was called from?

I'm not sure if I understand right, but the issue why we added it was that we should not allocate memory dynamically in the RT loop? which means, auto-reallocation of capacity will do exactly what we want to avoid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants