-
Notifications
You must be signed in to change notification settings - Fork 401
chore: tf2_ros to hpp headers #1866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: tf2_ros to hpp headers #1866
Conversation
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1866 +/- ##
=======================================
Coverage 85.92% 85.92%
=======================================
Files 133 133
Lines 13148 13148
Branches 1145 1145
=======================================
Hits 11297 11297
Misses 1480 1480
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but why do you change "" style to <>? google code style guide says, use "" wherever possible.
I was unaware of that styleguide! I thought "" was prefered for headers included in the package itself and <> for 'external' includes. This was just a (too lazy) regex. |
Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
no worries :)
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes |
e01c181
into
ros-controls:master
(cherry picked from commit e01c181)
No description provided.