Skip to content

Conversation

Timple
Copy link
Contributor

@Timple Timple commented Aug 18, 2025

No description provided.

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.92%. Comparing base (fcad0a3) to head (7b2318a).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1866   +/-   ##
=======================================
  Coverage   85.92%   85.92%           
=======================================
  Files         133      133           
  Lines       13148    13148           
  Branches     1145     1145           
=======================================
  Hits        11297    11297           
  Misses       1480     1480           
  Partials      371      371           
Flag Coverage Δ
unittests 85.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nce_controller/test/test_admittance_controller.hpp 94.88% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but why do you change "" style to <>? google code style guide says, use "" wherever possible.

@Timple
Copy link
Contributor Author

Timple commented Aug 18, 2025

I was unaware of that styleguide! I thought "" was prefered for headers included in the package itself and <> for 'external' includes.

This was just a (too lazy) regex.

Signed-off-by: Tim Clephas <tim.clephas@nobleo.nl>
@christophfroehlich
Copy link
Contributor

I was unaware of that styleguide! I thought "" was prefered for headers included in the package itself and <> for 'external' includes.

no worries :)

Headers should only be included using an angle-bracketed path if the library requires you to do so.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes

@christophfroehlich christophfroehlich merged commit e01c181 into ros-controls:master Aug 24, 2025
24 of 26 checks passed
@bmagyar bmagyar added the backport-jazzy Triggers PR backport to ROS 2 jazzy. label Aug 26, 2025
mergify bot pushed a commit that referenced this pull request Aug 26, 2025
(cherry picked from commit e01c181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy Triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants