Closed
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
mikaelarguedas
force-pushed
the
support_nested_array
branch
from
8230486 to
a6564d4
Compare
mikaelarguedas
commented
Feb 17, 2019
| except ValueError as e: | ||
| raise SetFieldError(field_name, e) | ||
| try: | ||
| f_type = msg.get_slot_types()['_' + field_name] |
Member
Author
There was a problem hiding this comment.
This looks pretty weird see ros2/rosidl_python#30 (comment) for more context and suggestion for stripping the leading underscores
mikaelarguedas
added
in review
Member
Author
|
Superseeded by #207 |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
…ents aren't optional (ros2#197) Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #59
Requires ros2/rosidl_python#30
Can be tested by following the steps of bug reports #59 or #191