Closed
Conversation
Signed-off-by: Mikael Arguedas <mikael.arguedas@gmail.com>
This was referenced Mar 13, 2019
mikaelarguedas
added
in review
dirk-thomas
reviewed
Mar 15, 2019
| # Check if field is an array of ROS message types | ||
| if isinstance(field_type(), list): | ||
| if isinstance(f_type.basetype, NamespacedType): | ||
| # TODO(mikaelarguedas) Consider putting this import logic in a rosidl function |
Member
There was a problem hiding this comment.
Maybe the new package from ros2/rosidl_python#34 would be a good place for this too.
Member
Author
|
Closing in favor of ros2/rosidl_python#33 and #209 |
esteve
pushed a commit
to esteve/ros2cli
that referenced
this pull request
Dec 16, 2022
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaces #197 now that ros2/rosidl_python#24 has merged.
Fixes #59
Note: the code for importing a message from a NamespacedType is inline for now. It could be refactored into a rosidl package but I'm unsure what the right place for it is, and it looks like the other import logic in this repo are also pending refactor
ros2cli/ros2topic/ros2topic/api/__init__.py
Lines 57 to 58 in 145542e
Can be tested by following the steps of bug reports #59 or #191
Requires ros2/rosidl_python#33