Skip to content

Feat/hanlde frames #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Feat/hanlde frames #1676

wants to merge 11 commits into from

Conversation

salomita
Copy link

@salomita salomita commented Apr 8, 2025

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0006a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hannadrehman
hannadrehman reviewed Sep 16, 2025
View reviewed changes
packages/rrweb-snapshot/src/rebuild.ts
@@ -325,7 +325,14 @@ function buildNode(
'rrweb-original-srcset',
n.attributes.srcset as string,
);
} else {
}
// Set the sandbox attribute on the iframe element will make it lose its contentDocument access and therefore cause additional playback errors.
Copy link

@hannadrehman hannadrehman Sep 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be related to this #1720 ?

@eoghanmurray
Copy link
Contributor

This definitely needs some tests to demonstrate the scenario!

See here for an example test (on something I never got to work) which you could adapt for this scenario:
master...eoghanmurray:rrweb:iframeInternalCrossOriginNav#diff-5d49baec098b78596f8d6ea614dcdb6a4f69ec9274b72e12f566b1f9ffb55f6d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hannadrehman hannadrehman hannadrehman left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
testcase needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@salomita @eoghanmurray @hannadrehman @charlie632