-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Feat/hanlde frames #1676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
salomita
wants to merge
11
commits into
rrweb-io:master
Choose a base branch
from
charlie632:feat/hanlde-frames
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+119
−8
Open
Feat/hanlde frames #1676
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3a68385
feat: allow replaying a single event
charlie632 6b286f8
change name of public method
charlie632 4a0bf34
errors with rebuild
charlie632 3a41e78
Merge pull request #1 from charlie632/charlie632/fix/styles
charlie632 b6fde03
Merge branch 'rrweb-io:master' into master
charlie632 7bf157d
Merge remote-tracking branch 'upstream/master'
charlie632 26106b8
feat: add support for frameset
salomita b9f8c63
Merge branch 'master' into feat/hanlde-frames
salomita 0b43a72
fix: add fix for iframes
salomita 6a48c91
feat: delete console log
salomita a0006a9
fix: ifx lint
salomita File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,7 +32,7 @@ | |
'now you can use replayer.getMirror() to access the mirror instance of a replayer,' + | ||
'\r\n' + | ||
'or you can use record.mirror to access the mirror instance during recording.'; | ||
/** @deprecated */ | ||
Check warning on line 35 in packages/rrweb/src/utils.ts
|
||
export let _mirror: DeprecatedMirror = { | ||
map: {}, | ||
getId() { | ||
|
@@ -116,7 +116,7 @@ | |
set(value) { | ||
// put hooked setter into event loop to avoid of set latency | ||
setTimeout(() => { | ||
d.set!.call(this, value); | ||
}, 0); | ||
if (original && original.set) { | ||
original.set.call(this, value); | ||
|
@@ -364,7 +364,9 @@ | |
n: TNode, | ||
mirror: IMirror<TNode>, | ||
): boolean { | ||
return Boolean(n.nodeName === 'IFRAME' && mirror.getMeta(n)); | ||
return Boolean( | ||
(n.nodeName === 'IFRAME' || n.nodeName === 'FRAME') && mirror.getMeta(n), | ||
); | ||
} | ||
|
||
export function isSerializedStylesheet<TNode extends Node | RRNode>( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -609,7 +609,7 @@ | |
export type customElementCallback = (c: customElementParam) => void; | ||
|
||
/** | ||
* @deprecated | ||
Check warning on line 612 in packages/types/src/index.ts
|
||
*/ | ||
interface INode extends Node { | ||
__sn: serializedNodeWithId; | ||
|
@@ -651,6 +651,7 @@ | |
on(type: string, handler: Handler): void; | ||
emit(type: string, event?: unknown): void; | ||
off(type: string, handler: Handler): void; | ||
all: Map<string | symbol, Handler[]>; | ||
}; | ||
|
||
export type Arguments<T> = T extends (...payload: infer U) => unknown | ||
|
@@ -675,6 +676,7 @@ | |
EventCast = 'event-cast', | ||
CustomEvent = 'custom-event', | ||
Flush = 'flush', | ||
FlushEnd = 'flush-end', | ||
StateChange = 'state-change', | ||
PlayBack = 'play-back', | ||
Destroy = 'destroy', | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be related to this #1720 ?