Fix parsing of nigthly targets #1517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix import order, sort them
This was referenced Aug 11, 2025
NobodyXu
pushed a commit
that referenced
this pull request
Sep 28, 2025
Without this change, we end up passing `aarch64-apple-ios26.0-macabimacabi` to the compiler, which is definitely wrong. The core change here is to handle this in `from_cargo_environment_variables` as well, the rest is just a cleanup now that `target.env` contains the canonical value (and `target.abi`). See also the previous #1517 and #1534.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#139451 updated the sim/macabi to be env instead of abi