Rollup of 11 pull requests #149682
Merged
Rollup of 11 pull requests #149682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple without changing doctests
There is a weak convention in the ecosystem that `IterFoos` is an iterator yielding items of type `Foo` (e.g. `bitflags` `IterNames`, `hashbrown` `IterBuckets`), while `FooIter` is an iterator over `Foo` from an `.iter()` or `.into_iter()` method (e.g. `memchr` `OneIter`, `regex` `SetMatchesIter`). Rename `IterRange`, `IterRangeInclusive`, and `IterRangeFrom` to `RangeIter`, `RangeInclusiveIter`, and `RangeInclusiveIter` to match this. Tracking issue: RUST-125687 (`new_range_api`)
…nfo. LLVM reference commit: llvm/llvm-project@04c81a9.
Tests for `-Zdebuginfo-compression=zstd` need to be skipped if LLVM was built without support for zstd compression. Currently, compiletest relies on messy and fragile heuristics to detect whether the compiler's LLVM was built with zstd support. But the compiler itself already knows whether LLVM has zstd or not, so it's easier for compiletest to just ask the compiler.
…r=joboet alloc: Document panics when allocations will exceed max Document panics in `String` and `Vec` due to capacity overflowing `isize::MAX`. Correct outdated claims of `usize::MAX` limit. Fixes rust-lang#148598. Ping `@lolbinarycat`
…ted, r=joboet core docs: rewrite `panic::Location::caller` with visual line/column numbers no tracking issue hey, this is my first PR on rust-lang/rust, so hopefully everything goes well. i noticed the documentation for `core::panic::Location::caller` was kind of unintelligible (and maybe even wrong due to standalone_crate) and filled with magic numbers, so i provided line and column numbers as a visual guidance as to how it should be used. edit: uh oh, looks like i pushed changes from random commits unrelated to me, what's going on? edit2: reverted the unintended changes by this pr
Improve mutable-binding suggestion to include name resolve: rust-lang#148467
float::maximum/minimum: make docs more streamlined This does with `maximum`/`minimum` what rust-lang#149475 did with `max`/`min`: first a self-contained description of the semantics, then comparing with other operations. It also makes the wording consistent with those other functions. Previously we had some of the semantics below the examples for some reason, and we repeated "If one of the arguments is NaN, then NaN is returned"; that has been streamlined as well. r? `@tgross35`
library: Rename `IterRange*` to `Range*Iter` There is a weak convention in the ecosystem that `IterFoos` is an iterator yielding items of type `Foo` (e.g. `bitflags` `IterNames`, `hashbrown` `IterBuckets`), while `FooIter` is an iterator over `Foo` from an `.iter()` or `.into_iter()` method (e.g. `memchr` `OneIter`, `regex` `SetMatchesIter`). Rename `IterRange`, `IterRangeInclusive`, and `IterRangeFrom` to `RangeIter`, `RangeInclusiveIter`, and `RangeInclusiveIter` to match this. Tracking issue: rust-lang#125687 (`new_range_api`)
…ochenkov Generate delegation error body when delegation is not resolved This PR relates to the delegation feature rust-lang#118212, it fixes rust-lang#144594 ICE. r? `@petrochenkov`
Check identifiers defined in macros when suggesting identifiers hidden by hygiene Fix rust-lang#149604 r? `@JonathanBrouwer` (Since you reviewed the other one related to this)
Add regression test for 141845 close: rust-lang#141845 I saw the `tests/ui/associated-inherent-types` directory, but I felt the current location was a better fit.
…fix, r=cuviper Fix for LLVM22 making lowering decisions dependent on RuntimeLibraryInfo. LLVM added codegen decision making based on RuntimeLibraryInfo. Mirror the change in Rust's codegen. LLVM reference commit: llvm/llvm-project@04c81a9.
Add perma-unstable `--print=backend-has-zstd` for use by compiletest Tests for `-Zdebuginfo-compression=zstd` need to be skipped if LLVM was built without support for zstd compression. Currently, compiletest relies on messy and fragile heuristics to detect whether the compiler's LLVM was built with zstd support. But the compiler itself already knows whether LLVM has zstd or not, so it's easier for compiletest to just ask the compiler. --- Originally I was intending for this to be a `--print=debuginfo-compression` flag that would print out a list of values supported by `-Zdebuginfo-compression=`. I got that working locally, but it was more complex than I was happy with (in both rustc and compiletest), so I decided to cut scope and instead add a very narrow perma-unstable print request instead. There is always a circularity hazard whenever we ask the compiler-under-test for information about how to test it. But in this case, the underlying compiler code is fairly simple, whereas the previous heuristics were inherently messy and unreliable anyway.
…r=mati865 interpret: test SNaN handling of float min/max and update comments Also see rust-lang#149563. I also renamed these enum variants so they are not almost identical.
rustbot
added
A-compiletest
rustbot
added
T-libs
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 97b131c (parent) -> 66428d9 (this PR) Test differencesShow 466 test diffsStage 1
Stage 2
Additionally, 444 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 66428d92bec337ed4785d695d0127276a482278c --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 97b131c900 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (66428d9): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 3.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.371s -> 470.249s (-0.03%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
panic::Location::callerwith visual line/column numbers #148811 (core docs: rewritepanic::Location::callerwith visual line/column numbers)IterRange*toRange*Iter#149547 (library: RenameIterRange*toRange*Iter)--print=backend-has-zstdfor use by compiletest #149666 (Add perma-unstable--print=backend-has-zstdfor use by compiletest)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup