-
Notifications
You must be signed in to change notification settings - Fork 335
Sync crate owners on crates.io #2151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Dry-run check results |
|
merging this PR will remove other owners, right? |
|
I see, I didn't realize we still have crates with individual owners. Ok, then that logic will have to wait, and I'll rework this PR slightly. |
cb95045 to
c5797d3
Compare
|
If you are changing the data structures, please make sure that the changes are not going to break serde deserialization (adding a field is fine; removing or renaming a field isn't). If you must do a breaking change to the format, make sure to coordinate it with all the users of the |
|
Ok, new version, now it should do complete sync of team owners. |
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably contact crate owners that would get removed with this to let them know, maybe confirm they're ok with it.
|
In the current state, this would only remove team, not user, owners, and it should not actually remove anyone, as long as I backfilled the teams currently. We only have 5 repos with crates tracked in team currently. |
cb1f225 to
061c994
Compare
|
Rebased. |
|
Removed invitation of |
b2bc0fa to
c9225b3
Compare
c9225b3 to
e41a350
Compare
|
Rebased over the recent changes to the crates.io syncing logic. Unlike trusted publishing, the dry-run should actually work here (still has to be done in a separate PR though). |
This PR implements sync of crate ownership on crates.io (#2134 (review)). It allows configuring Rust teams that own a given crate on crates.io, and synces the team ownership on crates.io.
It does not yet remove user ownership for other accounts than
rust-lang-owner; we first need to transition some crates to team ownership before that.Best reviewed commit-by-commit.
CC @Mark-Simulacrum