Add stopping condition for while loop#76
Merged
sdfordham merged 1 commit intosdfordham:mainfrom Apr 11, 2025
ConorMcNamara:main
Merged
Add stopping condition for while loop#76sdfordham merged 1 commit intosdfordham:mainfrom ConorMcNamara:main
sdfordham merged 1 commit intosdfordham:mainfrom
ConorMcNamara:main
Conversation
The while loop in robust.py assumes that we've specified a high enough threshold to end. However, if the threshold is low enough, we will continue looping until we try to access an element that is beyond the size of s, creating an error. We have now added a stopping condition to that.
Owner
|
Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The while loop in robust.py assumes that we've specified a high enough threshold to end. However, if the threshold is low enough, we will continue looping until we try to access an element that is beyond the size of s, creating an error. We have now added a stopping condition to that.