Skip to content

Add stopping condition for while loop #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdfordham merged 1 commit into from
Apr 11, 2025
Merged

Add stopping condition for while loop #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pysyncon/robust.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,10 @@ def _sv_decomposition(
if not threshold and not sv_count:
raise ValueError("One of `threshold` or `sv_count` must be supplied.")
u, s, v = np.linalg.svd(Y)
s_shape = s.shape[0] - 1
if threshold:
idx = 0
while s[idx] > threshold:
while s[idx] > threshold and idx < s_shape:
idx += 1
else:
idx = sv_count
Expand Down