Fix for non-zero initial tab index not sizing children correctly and device orientation change issue#12
Open
mzelldev wants to merge 1 commit intoshubhamhackz:masterfrom
Open
Fix for non-zero initial tab index not sizing children correctly and device orientation change issue#12mzelldev wants to merge 1 commit intoshubhamhackz:masterfrom
mzelldev wants to merge 1 commit intoshubhamhackz:masterfrom
Conversation
…device orientation change support This commit fixes two issues: - When the tabController.index was initial set to something > 0, the height for the children was not being calculated correctly. - When changing the device orientation (portrait/landscape) the height was not being updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for non-zero initial tab index not sizing children correctly and device orientation change issue
This commit fixes two issues: