Skip to content

Fix for non-zero initial tab index not sizing children correctly and device orientation change issue #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mzelldev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for non-zero initial tab index not sizing children correctly and device orientation change issue #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions lib/src/size_detector_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,9 @@ class SizeDetectorWidget extends StatefulWidget {
class _SizeDetectorWidgetState extends State<SizeDetectorWidget> {
Size? _oldSize;

@override
void initState() {
super.initState();
SchedulerBinding.instance?.addPostFrameCallback((_) => _detectSize());
}

@override
Widget build(BuildContext context) {
SchedulerBinding.instance?.addPostFrameCallback((_) => _detectSize());
return widget.child;
}

Expand Down
23 changes: 15 additions & 8 deletions lib/src/sized_pageview.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ class SizedPageView extends StatefulWidget {
_SizedPageViewState createState() => _SizedPageViewState();
}

class _SizedPageViewState extends State<SizedPageView>
with TickerProviderStateMixin {
class _SizedPageViewState extends State<SizedPageView> with TickerProviderStateMixin {
late List<double> _heights;
int _currentIndex = 0;

Expand All @@ -32,14 +31,13 @@ class _SizedPageViewState extends State<SizedPageView>
void initState() {
super.initState();
_heights = List.generate(widget.children.length, (index) => 0.0);
final int initialIndex = widget.pageController.initialPage;
_setCurrentIndex(initialIndex);

widget.pageController.addListener(() {
final _newIndex = widget.pageController.page?.round();
if (_currentIndex != _newIndex) {
if (!mounted) {
return;
}
setState(() => _currentIndex = _newIndex!);
final int? newIndex = widget.pageController.page?.round();
if (newIndex != null) {
_setCurrentIndex(newIndex);
}
});
}
Expand Down Expand Up @@ -79,4 +77,13 @@ class _SizedPageViewState extends State<SizedPageView>
widget.pageController.dispose();
super.dispose();
}

void _setCurrentIndex(int newIndex) {
if (_currentIndex != newIndex) {
if (!mounted) {
return;
}
setState(() => _currentIndex = newIndex);
}
}
}