Skip to content

Docs/icon button square #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
spike-rabbit merged 1 commit into from
Jan 29, 2026
Merged

Docs/icon button square #1218

spike-rabbit merged 1 commit into from
Jan 29, 2026

Conversation

@panch1739
Copy link
Member

@panch1739 panch1739 commented Dec 17, 2025 •
edited
Loading

This PR adds documentation for the square icon button

Related to #1215

@panch1739 panch1739 added this to the 49.0.0 milestone Dec 17, 2025
@panch1739 panch1739 requested a review from hbxes December 17, 2025 16:27
@panch1739 panch1739 added documentation Improvements or additions to documentation ux Marks all UX related topics (UX team is working on or UX input is required) labels Dec 17, 2025
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Documentation.
Examples.
Playwright report.

Coverage Reports:

@panch1739 panch1739 mentioned this pull request Jan 7, 2026
Closed
1 task
@panch1739 panch1739 mentioned this pull request Jan 20, 2026
Merged
1 task
@panch1739 panch1739 force-pushed the docs/icon-button-square branch from e015596 to 672f581 Compare January 20, 2026 08:38
hbxes
hbxes reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@hbxes hbxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment I've sent you via TEAMS, other it's ok

hbxes
hbxes reviewed Jan 22, 2026
View reviewed changes
hbxes
hbxes reviewed Jan 22, 2026
View reviewed changes
hbxes
hbxes reviewed Jan 22, 2026
View reviewed changes
Copy link
Member

@hbxes hbxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the different comments otherwise it's short and consice, that what buttons are...

@panch1739
Copy link
Member Author

panch1739 commented Jan 22, 2026

@hbxes I addressed all the points, including our conversation in teams :)

@panch1739 panch1739 force-pushed the docs/icon-button-square branch from c0f6b3d to 7cdac87 Compare January 22, 2026 15:01
@panch1739 panch1739 marked this pull request as ready for review January 22, 2026 16:14
@panch1739 panch1739 requested review from a team as code owners January 22, 2026 16:14
spike-rabbit
spike-rabbit approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit force-pushed the docs/icon-button-square branch from 7cdac87 to d272827 Compare January 29, 2026 08:09
@spike-rabbit spike-rabbit enabled auto-merge (rebase) January 29, 2026 08:10
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Code Coverage

@spike-rabbit spike-rabbit merged commit 222283c into main Jan 29, 2026
10 checks passed
@spike-rabbit spike-rabbit deleted the docs/icon-button-square branch January 29, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hbxes hbxes hbxes left review comments

@spike-rabbit spike-rabbit spike-rabbit approved these changes

@kfenner kfenner Awaiting requested review from kfenner

@dauriamarco dauriamarco Awaiting requested review from dauriamarco

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation ux Marks all UX related topics (UX team is working on or UX input is required)

Projects

None yet

Milestone

49.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@panch1739 @spike-rabbit @hbxes