Skip to content

Conversation

PranavBhatP
Copy link
Contributor

Reference Issues/PRs

#1966

What does this implement/fix? Explain your changes.

Fix #1966.
Uncovered non-conformances:

  1. TimeXer
  2. NBeatsKAN (newest estimator)
  3. NBeats
  4. xLSTMTime

This PR enforces testing of the estimators' output format on only one case - [batch_size, prediction_length, loss_dim]. The non-conformance in the above mentioned models, was the presence of 2D output for single targets case.

What should a reviewer concentrate their feedback on?

Did you add any tests for the change?

Any other comments?

PR checklist

  • The PR title starts with either [ENH], [MNT], [DOC], or [BUG]. [BUG] - bugfix, [MNT] - CI, test framework, [ENH] - adding or improving code, [DOC] - writing or improving documentation or docstrings.
  • Added/modified tests
  • Used pre-commit hooks when committing to ensure that code is compliant with hooks. Install hooks with pre-commit install.
    To run hooks independent of commit, execute pre-commit run --all-files

this commit ensures only a single branch of testing on the output format [batch_size, prediction_length, loss_dim] and skips the test for non-conformant estimators
@fkiraly fkiraly added enhancement New feature or request module:models labels Sep 18, 2025
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a3bc452). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1971   +/-   ##
=======================================
  Coverage        ?   85.32%           
=======================================
  Files           ?      158           
  Lines           ?     9296           
  Branches        ?        0           
=======================================
  Hits            ?     7932           
  Misses          ?     1364           
  Partials        ?        0           
Flag Coverage Δ
cpu 85.32% <100.00%> (?)
pytest 85.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -5,6 +5,10 @@
EXCLUDE_ESTIMATORS = [
"DummySkipped",
"ClassName", # exclude classes from extension templates
"NBeatsKAN_pkg",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also add "tests:skip_by_name" tag in corresponding _pkg classes. There if you add test_integration it should skip the integration tests for that model class. This would not skip other tests for that model, like it is now, where framework is skipping the whole _pkg class.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, although afaik we would have to add the machinery for that tag in pytorch-forecasting first. I do not think it works out of the box right now, since I have not added that feature to scikit-base yet. There is code in sktime that could be copied for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it exists! we already brought it (and modified it for _pkg usage) from sktime. See here
We are already using it to skip specific params for some buggy fixtures(like LogNormalDistributionLoss for DecoderMLP, see here). So, I think we could use it here as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request module:models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] improve _integration in TestAllEstimators to address non-conformace of TimeXer and NBeats
3 participants