-
Notifications
You must be signed in to change notification settings - Fork 705
[ENH] Standardize testing of estimator outputs and skip tests for non-conformant estimators #1971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PranavBhatP
wants to merge
6
commits into
sktime:main
Choose a base branch
from
PranavBhatP:test-all-estimators-patch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−18
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
052c696
standardise testing and skip tests for non-conformance
PranavBhatP e1f5c95
restrict output ndim in testing to 3
PranavBhatP a52ef18
Update test_all_estimators.py
PranavBhatP 3171ba7
Update test_all_estimators.py
PranavBhatP 725e605
add correct package names for skipping tests
PranavBhatP 591e4e0
Merge branch 'main' into test-all-estimators-patch
PranavBhatP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could also add
"tests:skip_by_name"
tag in corresponding_pkg
classes. There if you addtest_integration
it should skip theintegration
tests for that model class. This would not skip other tests for that model, like it is now, where framework is skipping the whole_pkg
class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, although afaik we would have to add the machinery for that tag in
pytorch-forecasting
first. I do not think it works out of the box right now, since I have not added that feature toscikit-base
yet. There is code insktime
that could be copied for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it exists! we already brought it (and modified it for
_pkg
usage) fromsktime
. See hereWe are already using it to skip specific params for some buggy fixtures(like
LogNormalDistributionLoss
forDecoderMLP
, see here). So, I think we could use it here as well...