added game difficulty, game gets harder every 500 points #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
slugo
requested changes
Aug 2, 2017
Owner
slugo
left a comment
slugo
left a comment
There was a problem hiding this comment.
Hey, thanks for the pull request! I've checked the changes and everything seems fine, but can we modify the difficulty calculations? I've tested it and after 1000pts it gets reaaally fast. Maybe we can make it increase more slowly. After that is changed we can merge the pr.
slugo
reviewed
Aug 2, 2017
| { | ||
| const delta = 100; | ||
| const difficultyPoints = action.points + state.difficultyPoints; | ||
| const difficulty = state.difficulty - 50 * Math.floor(difficultyPoints / delta); |
Owner
There was a problem hiding this comment.
This is the calculation I'm referring to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added game difficulty. Game gets faster every 500 points.