fix: correct awk range to stop redis-exporter version loop#46
Merged
1 commit merged intomainfrom Mar 3, 2026
Merged
Conversation
The awk range pattern /^metrics:/,/^[a-z]+:/ was broken because "metrics:" matches BOTH the start and end patterns simultaneously. In awk, when both patterns match the same line, the range opens and closes immediately — so the body never runs and CURRENT is always empty. Since any real version != "", the workflow always detected a "new update" for redis-exporter, creating the same PR on every run. Two bugs fixed: - Replace the broken range with a flag-based approach (found=1; next) that skips the "metrics:" line before checking the exit condition. - Replace /^\s+tag:/ with /^ +tag:/ since \s is not POSIX awk. https://claude.ai/code/session_01MDiuwf2FT7zd7aqGhTBuCL
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The awk range pattern /^metrics:/,/^[a-z]+:/ was broken because "metrics:" matches BOTH the start and end patterns simultaneously. In awk, when both patterns match the same line, the range opens and closes immediately — so the body never runs and CURRENT is always empty. Since any real version != "", the workflow always detected a "new update" for redis-exporter, creating the same PR on every run.
Two bugs fixed:
https://claude.ai/code/session_01MDiuwf2FT7zd7aqGhTBuCL