Skip to content
This repository was archived by the owner on Jan 21, 2018. It is now read-only.

Feature/mbed interface#22

Open
JoshuaBRussell wants to merge 44 commits intodevelopfrom
feature/mbed_interface
Open

Feature/mbed interface#22
JoshuaBRussell wants to merge 44 commits intodevelopfrom
feature/mbed_interface

Conversation

@JoshuaBRussell
Copy link
Copy Markdown

Adding node to communicate with the MBed over USB

@JacobAMason JacobAMason force-pushed the feature/mbed_interface branch 3 times, most recently from c158261 to 4373978 Compare December 20, 2016 01:32
Copy link
Copy Markdown
Member

@JacobAMason JacobAMason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgrayd @JoshuaBRussell I'm pretty sure I cleaned this up right. You guys probably want to check and make sure, though, even though travis passed it.

@bgrayd bgrayd self-requested a review January 26, 2017 19:06
Comment thread cr17/nodes/cr17/mbed_interface.py Outdated
Sends low-level commands(scoop, arm, linear velocity, angular velocity) to Mbed over USB.
Also accepts speed values from Mbed for each wheel, and publishes to the wheel_speed topic.

This node must be run under su privelages. I've been doing it using sudo su, then the command to run the node.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you make a launch file for this, and then on the node tag for this node add 'launch-prefix="sudo -E " ' it will handle the privileges and you won't need to run sudo su first.

@JacobAMason
Copy link
Copy Markdown
Member

@JoshuaBRussell Might need to apt-get python-usb. Not all that sure.

Comment thread cr17/package.xml Outdated
<run_depend>rospy</run_depend>
<run_depend>std_msgs</run_depend>
<run_depend>joy</run_depend>
<run_depend>libusb-1.0</run_depend>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tabbing

Comment thread cr17/package.xml Outdated
<run_depend>std_msgs</run_depend>
<run_depend>joy</run_depend>
<run_depend>libusb-1.0</run_depend>
<run_depend>pyusb</run_depend>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tabbing

@JacobAMason
Copy link
Copy Markdown
Member

@bgrayd Is this PR good to go?

@JoshuaBRussell
Copy link
Copy Markdown
Author

@JacobAMason It is not. I still need to test the config with the MBed itself, and I can't do that until Monday. Also need to test the sudo -E suggestion from Billy

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants