Skip to content

Fix crash with libGDX unable to load empty strings as icons#111

Merged
stringdotjar merged 1 commit intodevelopfrom
bugfix/no-window-icons
Apr 5, 2026
Merged

Fix crash with libGDX unable to load empty strings as icons#111
stringdotjar merged 1 commit intodevelopfrom
bugfix/no-window-icons

Conversation

@stringdotjar
Copy link
Copy Markdown
Owner

Description

This PR fixes a crash that allowed developers to pass broken strings as window icons.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor / Optimization
  • Other (please specify in description)

Checklist

  • My PR targets the develop branch, not master/main.
  • My code follows the code style of this project (if any code was added or changed).
  • I have performed a self-review of my own code (if any code was added or changed).
  • I have commented my code, particularly in hard-to-understand areas (if any code was added or changed).
  • My changes pass all automated build checks.
  • I have updated the documentation accordingly (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if any code was added or changed).

Screenshots / Evidence (if applicable)

Add screenshots or logs to help explain your changes.

@stringdotjar stringdotjar self-assigned this Apr 5, 2026
@stringdotjar stringdotjar added core Core logic module of the framework approved This pull request passes all requirements and is ready to be merged bug fix A solution was made for a problem that caused unintended output labels Apr 5, 2026
@stringdotjar stringdotjar moved this from 🗒️ Todo to 💯 Approved in FlixelGDX Project Board Apr 5, 2026
@stringdotjar stringdotjar merged commit cbf9572 into develop Apr 5, 2026
8 checks passed
@github-project-automation github-project-automation bot moved this from 💯 Approved to ✅ Completed in FlixelGDX Project Board Apr 5, 2026
@stringdotjar stringdotjar deleted the bugfix/no-window-icons branch April 6, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This pull request passes all requirements and is ready to be merged bug fix A solution was made for a problem that caused unintended output core Core logic module of the framework

Projects

Status: ✅ Completed

Development

Successfully merging this pull request may close these issues.

1 participant