Skip to content

Fix crash with libGDX unable to load empty strings as icons #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stringdotjar merged 1 commit into from
Apr 5, 2026
Merged

Fix crash with libGDX unable to load empty strings as icons #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions ...x-lwjgl3/src/main/java/me/stringdotjar/flixelgdx/backend/lwjgl3/FlixelLwjgl3Launcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@

package me.stringdotjar.flixelgdx.backend.lwjgl3;

import java.util.Arrays;
import java.util.Objects;

import com.badlogic.gdx.backends.lwjgl3.Lwjgl3Application;
import com.badlogic.gdx.backends.lwjgl3.Lwjgl3ApplicationConfiguration;
import com.badlogic.gdx.backends.lwjgl3.Lwjgl3WindowAdapter;
Expand All @@ -25,7 +28,8 @@ public class FlixelLwjgl3Launcher {

/**
* Launches the LWJGL3 version of the Flixel game in {@link FlixelRuntimeMode#RELEASE RELEASE}
* mode and with a default configuration object.
* mode and with a default configuration object. This should be called from the main method of the
* libGDX LWJGL3 launcher class, and the game instance should be created in the same general area.
*
* @param game The game instance to launch.
*/
Expand All @@ -39,7 +43,7 @@ public static void launch(FlixelGame game) {
* libGDX LWJGL3 launcher class, and the game instance should be created in the same general area.
*
* @param game The game instance to launch.
* @param icons Window icon paths.
* @param icons Window icon paths. Make sure your icons actually exist and are valid!
*/
public static void launch(FlixelGame game, String... icons) {
launch(game, FlixelRuntimeMode.RELEASE, icons);
Expand All @@ -52,7 +56,7 @@ public static void launch(FlixelGame game, String... icons) {
*
* @param game The game instance to launch.
* @param runtimeMode The {@link FlixelRuntimeMode} for this session (TEST, DEBUG, or RELEASE).
* @param icons Window icon paths.
* @param icons Window icon paths. Make sure your icons actually exist and are valid!
*/
public static void launch(FlixelGame game, FlixelRuntimeMode runtimeMode, String... icons) {
Lwjgl3ApplicationConfiguration configuration = new Lwjgl3ApplicationConfiguration();
Expand All @@ -64,7 +68,12 @@ public static void launch(FlixelGame game, FlixelRuntimeMode runtimeMode, String
} else {
configuration.setWindowedMode(game.getViewWidth(), game.getViewHeight());
}
configuration.setWindowIcon(icons);
// Ensure the icons are not null, empty, or whitespace only.
configuration.setWindowIcon(Arrays.stream(icons)
.filter(Objects::nonNull)
.map(String::trim)
.filter(s -> !s.isEmpty())
.toArray(String[]::new));
configuration.setWindowListener(new Lwjgl3WindowAdapter() {
@Override
public void focusGained() {
Expand Down
Loading