Skip to content

Conversation

@max-models
Copy link
Member

@max-models max-models commented Oct 31, 2025

Redo of #50

Solves the following issue(s):

Closes #45

Core changes:

There are now four PR workflows that must pass for a feature to be merged:

  1. unit
  2. models
  3. pure Python
  4. with clones

Tests are made with and without MPI with --testmon. Testmon data is cached for the next workflow run to use. Cache cannot be altered, thus new cache keys are necessary in every run. The key convention is, for unit tests for example:

key: testmon-unit-${{ github.event.number }}-${{ github.run_number }}
restore-keys: |
    testmon-unit-${{ github.event.number }}-
    testmon-unit-

The event.number is the number of the PR. The run_number refers to the workflow run, thus it increases monotonically. The one that is fetched has a run number one less than the current run, and is thus the most recent.

@max-models max-models changed the base branch from devel to devel-clean October 31, 2025 20:27
@spossann
Copy link
Member

@max-models what is the status on this one? It would be really nice to have it working to shorten the time of unit tests.

@max-models
Copy link
Member Author

@max-models what is the status on this one? It would be really nice to have it working to shorten the time of unit tests.

I think it already works for the single core unit tests, but not for the MPI tests. I don't have any time to finish it this week, the best option would probably be to do it in two separate PRs.

@spossann spossann marked this pull request as ready for review November 21, 2025 15:42
@spossann spossann self-requested a review November 21, 2025 15:42
spossann
spossann previously approved these changes Nov 21, 2025
@spossann
Copy link
Member

@max-models could please also review this? Thx!

@max-models
Copy link
Member Author

@max-models could please also review this? Thx!

Of course!

@max-models max-models requested a review from spossann November 21, 2025 22:02
@max-models
Copy link
Member Author

I would approve the PR now, but I can't because I'm the author of the PR. Can you do it?

@spossann spossann merged commit f5ce047 into devel Nov 22, 2025
8 checks passed
@spossann spossann deleted the clean-45-only-run-the-unit-tests-which-touch-changed-code-in-the-ci branch November 22, 2025 07:48
@max-models
Copy link
Member Author

max-models commented Nov 22, 2025

Nice! I expect this to speed up development by 100x :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only run the unit tests which touch changed code in the CI

3 participants