-
Notifications
You must be signed in to change notification settings - Fork 0
Only run the unit tests which touch changed code in the ci #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only run the unit tests which touch changed code in the ci #96
Conversation
…h-changed-code-in-the-ci
…h-changed-code-in-the-ci
|
@max-models what is the status on this one? It would be really nice to have it working to shorten the time of unit tests. |
I think it already works for the single core unit tests, but not for the MPI tests. I don't have any time to finish it this week, the best option would probably be to do it in two separate PRs. |
…h-changed-code-in-the-ci
…h-changed-code-in-the-ci
Co-authored-by: Max <max.lindqvist@ipp.mpg.de>
Co-authored-by: Max <max.lindqvist@ipp.mpg.de>
|
@max-models could please also review this? Thx! |
Of course! |
…bsdo not exist upon first execution); add mpi tests to pure python
|
I would approve the PR now, but I can't because I'm the author of the PR. Can you do it? |
|
Nice! I expect this to speed up development by 100x :) |
Redo of #50
Solves the following issue(s):
Closes #45
Core changes:
There are now four PR workflows that must pass for a feature to be merged:
Tests are made with and without MPI with
--testmon. Testmon data is cached for the next workflow run to use. Cache cannot be altered, thus new cache keys are necessary in every run. The key convention is, for unit tests for example:The
event.numberis the number of the PR. Therun_numberrefers to the workflow run, thus it increases monotonically. The one that is fetched has a run number one less than the current run, and is thus the most recent.