fix: make repl console scrollable #1477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| @@ -121,7 +121,8 @@ | |||
| } | |||
|
|
|||
| .panel-body { | |||
| overflow: auto; | |||
| overflow: scroll; | |||
| max-height: 100%; | |||
There was a problem hiding this comment.
This fixes it but makes it bigger than its current size because it fills the height of the container and doesn't take into account the height of the console controls we have at the top. This causes some of the console logs to be hidden. I wonder if we can easily fix this by wrapping the panel body in another container.
|
Another issue(?) I've found is that the console doesn't auto scroll to new logs if it's exceeded the height of the container. But maybe that's an issue for another day |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the console in the REPL has had
overflow: hidden, meaning that if there are too many logs to fit in the current view, you'd have to resize the console instead of just scrolling. This should fix that.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.