-
-
Notifications
You must be signed in to change notification settings - Fork 171
fix: make repl console scrollable #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ocean-OS
wants to merge
11
commits into
main
Choose a base branch
from
fix-console-scroll
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−0
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
a1f4b1a
fix: make repl console scrollable
Ocean-OS b6c094e
try this
Ocean-OS f2ba622
try this
Ocean-OS 390587a
i think i fixed it?
Ocean-OS 49133bf
Merge branch 'main' into fix-console-scroll
Ocean-OS 4852626
Merge branch 'main' into fix-console-scroll
Ocean-OS bac3986
Merge branch 'main' into fix-console-scroll
Ocean-OS 930da93
apply suggestion from review
Ocean-OS fbe867f
Merge branch 'main' into fix-console-scroll
Ocean-OS 5f269ee
Merge branch 'main' into fix-console-scroll
Ocean-OS 3d5a777
Merge branch 'main' into fix-console-scroll
eltigerchino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -122,6 +122,7 @@ | |
|
|
||
| .panel-body { | ||
| overflow: auto; | ||
| max-height: 100%; | ||
| } | ||
|
|
||
| .panel-heading { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes it but makes it bigger than its current size because it fills the height of the container and doesn't take into account the height of the console controls we have at the top. This causes some of the console logs to be hidden. I wonder if we can easily fix this by wrapping the panel body in another container.