Use custom notation for platform conditions where necessary in manifest code generation
#9169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omochi
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
cmcgee1024,
daveyc123 and
rconnell9
as code owners
jakepetroules
approved these changes
Sep 22, 2025
|
@swift-ci test |
|
@swift-ci test windows |
|
@jakepetroules Could you please merge this since the CI has passed? |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
customnotation for platform conditions where necessary in manifest code generationMotivation:
Currently, for platform cases that are known but not yet available, or entirely unknown, the generated code becomes invalid.
Modifications:
Change the implementation so that such cases are expressed using
customnotation.Result:
Manifest code generation will correctly handle known-but-unavailable and unknown platform conditions by outputting them with
customnotation.Additional Context:
In practice,
swift-subprocessincludes.custom("freebsd")in its manifest.When this is imported, source code is generated, and then reloaded with SwiftPM, the following error occurs:
This change prevents such errors by ensuring unsupported or future platforms are represented as
custom.