Skip to content

Use custom notation for platform conditions where necessary in manifest code generation #9169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2025
Merged

Use custom notation for platform conditions where necessary in manifest code generation #9169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion Sources/PackageModel/ManifestSourceGeneration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,19 @@ fileprivate extension SourceCodeFragment {
case "watchos": return SourceCodeFragment(enum: "watchOS")
case "visionos": return SourceCodeFragment(enum: "visionOS")
case "driverkit": return SourceCodeFragment(enum: "driverKit")
default: return SourceCodeFragment(enum: platformName)

// Among known cases, those not requiring capitalization changes
case "linux", "windows", "android", "wasi", "openbsd":
return SourceCodeFragment(enum: platformName)

// Known cases but not yet available
case "freebsd": fallthrough
default:
// For unknown cases, output using custom notation
return SourceCodeFragment(
enum: "custom",
subnodes: [.init(string: platformName)]
)
}
}
if !platformNodes.isEmpty {
Expand Down
3 changes: 2 additions & 1 deletion Tests/WorkspaceTests/ManifestSourceGenerationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,8 @@ final class ManifestSourceGenerationTests: XCTestCase {
dependencies: [
.target(name: "MyLib", condition: .when(platforms: [
.macOS, .macCatalyst, .iOS, .tvOS, .watchOS, .visionOS,
.driverKit, .linux, .windows, .android, .wasi, .openbsd
.driverKit, .linux, .windows, .android, .wasi, .openbsd,
.custom("freebsd"), .custom("toasterOS")
]))
]
),
Expand Down