Skip to content

Fix SonarCloud S2933: Mark unmodified fields as readonly in TaskStateManager #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thalesraymond merged 1 commit into from
Mar 19, 2026
+6 −6
Merged

Fix SonarCloud S2933: Mark unmodified fields as readonly in TaskStateManager #210

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/TaskStateManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ import { EventBus } from "./EventBus.js";
* Handles dependency resolution and event emission for state changes.
*/
export class TaskStateManager<TContext> {
private results = new Map<string, TaskResult>();
private readonly results = new Map<string, TaskResult>();
private pendingSteps = new Set<TaskStep<TContext>>();
private running = new Set<string>();
private readonly running = new Set<string>();

// Optimization structures
private dependencyGraph = new Map<string, TaskStep<TContext>[]>();
private dependencyCounts = new Map<string, number>();
private readonly dependencyGraph = new Map<string, TaskStep<TContext>[]>();
private readonly dependencyCounts = new Map<string, number>();
private readyQueue: TaskStep<TContext>[] = [];
private taskDefinitions = new Map<string, TaskStep<TContext>>();
private readonly taskDefinitions = new Map<string, TaskStep<TContext>>();

constructor(private eventBus: EventBus<TContext>) {}
constructor(private readonly eventBus: EventBus<TContext>) {}

/**
* Initializes the state with the given steps.
Expand Down
Loading