Add koji build support #303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
force-pushed
the
add-koji-build-support
branch
2 times, most recently
from
df70698 to
f932626
Compare
This was referenced Jun 1, 2022
2 tasks
evgeni
reviewed
Jul 13, 2022
evgeni
reviewed
Jul 13, 2022
Member
|
I like this! In the past, we talked about an extension of the form "if the build exists, but wasn't tagged into the right tag, obal should do that for us". Is this something that should be in this PR, or rather built ontop of this later? (I'd probably think "later", but wanted to ask) |
Member
|
And now I have seen #306 and shut the fuck up! |
ehelms
force-pushed
the
add-koji-build-support
branch
2 times, most recently
from
61fa632 to
985a11f
Compare
Member
Author
|
This now includes updated tests |
evgeni
reviewed
Jul 13, 2022
evgeni
reviewed
Jul 13, 2022
| package = module.params['package'] | ||
| koji_executable = module.params['koji_executable'] | ||
|
|
||
| if module.params['tag_check']: |
Member
There was a problem hiding this comment.
since #227 we default build_package_koji_whitelist_check to false, so this is not getting explicitly tested.
if you want, you could add an own test, but I would not block on that.
ehelms
force-pushed
the
add-koji-build-support
branch
from
985a11f to
25c2049
Compare
evgeni
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires --
#302This is an evolution of #230 where this PR adds the functionality and the ability to enable this functionality directly through a flag. All existing projects using this will continue to use tito as before. But projects can opt in to testing/using builds directly through koji by setting: