Skip to content

Conversation

@ehelms
Copy link
Member

@ehelms ehelms commented Jun 1, 2022

No description provided.

@ehelms ehelms changed the title Tag pkg if already built Tag package build into tag if it already exists Jun 1, 2022
@ehelms ehelms force-pushed the tag-pkg-if-already-built branch from f94a34c to 7f2f4a4 Compare June 1, 2022 14:19
@ehelms
Copy link
Member Author

ehelms commented Jun 1, 2022

This requires:

Worth noting is that this only adds the feature of tagging an existing build into a tag for the workflow that uses Koji build and not the tito workflow due to the need for tag granularity.

My over arching goal is to help solve the problem where a build goes into a nightly tag and then needs to be back-ported to a release branch.

@evgeni
Copy link
Member

evgeni commented Jul 14, 2022

guess this needs a rebase now :)

@ehelms ehelms force-pushed the tag-pkg-if-already-built branch from 7f2f4a4 to d8e23a2 Compare July 15, 2022 01:56
@ehelms ehelms force-pushed the tag-pkg-if-already-built branch from d8e23a2 to e3d667d Compare July 15, 2022 13:30
@ehelms
Copy link
Member Author

ehelms commented Jul 15, 2022

Issues addressed, I also put a few extra checks in to reduce the number of calls out. Notably, I am skipping the call to diff_package when using the new koji build process as that checking and subequent actions are all built into the workflow.

@ehelms
Copy link
Member Author

ehelms commented Jul 16, 2022

I had forgot will also need #272 to pull into this code

@ehelms ehelms requested a review from evgeni July 18, 2022 12:16
@evgeni
Copy link
Member

evgeni commented Jul 18, 2022

Request for Rebase!

@ehelms ehelms force-pushed the tag-pkg-if-already-built branch from e3d667d to c65c85b Compare July 18, 2022 13:21
@ehelms ehelms force-pushed the tag-pkg-if-already-built branch from c65c85b to 22000d0 Compare July 18, 2022 13:48
@evgeni evgeni merged commit f8aee8a into theforeman:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants