Add ability to check if package exists in Koji #305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is a small step towards adding the ability to detect if a build exists and then tag it in to a tag. |
evgeni
reviewed
Jul 13, 2022
Member
|
I'd love to see tests added for this! Love the feature! |
Previously, the check_koji_build only allowed checking if a package build existed within a tag, this allows checking if the build exists in Koji anywhere.
ehelms
force-pushed
the
add-ability-check-if-build-exists
branch
from
2b4bf7a to
9095a07
Compare
Member
Author
Hrmm, so today we do not have direct module tests, and this new functionality is not actually used until https://github.com/theforeman/obal/pull/306/files#diff-3fa87caeaa20d79dd42a779614b1c8a7b57acd53cbe929aa3cc55274f6223eb2R10 . So adding new tests is hard... I can close this an incorporate this change only in #306 ? |
evgeni
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check_koji_build only allowed checking if a package
build existed within a tag, this allows checking if the build exists
in Koji anywhere.