Add copr chroot options for RPM conditionals #419
+20
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogajduse
approved these changes
Nov 27, 2025
ekohl
force-pushed
the
add-copr-chroot-conditionals
branch
2 times, most recently
from
c7c960f to
2ba55c3
Compare
Member
|
the new options need to be added to diff --git a/tests/fixtures/mockbin/mockbin b/tests/fixtures/mockbin/mockbin
index 9697b00..50ada49 100755
--- a/tests/fixtures/mockbin/mockbin
+++ b/tests/fixtures/mockbin/mockbin
@@ -191,6 +191,8 @@ elif prog in ['copr-cli']:
parser_build.add_argument('--repos')
parser_build.add_argument('--packages')
parser_build.add_argument('--modules')
+ parser_build.add_argument('--rpmbuild-with', action='append')
+ parser_build.add_argument('--rpmbuild-without', action='append')
parser_build.add_argument('--upload-comps')
parser_build = subparsers.add_parser('watch-build') |
ekohl
force-pushed
the
add-copr-chroot-conditionals
branch
from
2ba55c3 to
d794ce3
Compare
RPM conditionals[1] allow building with and without certain features. This can be used to bootstrap builds, like foreman needing foreman-build which is built from foreman. [1]: https://rpm-software-management.github.io/rpm/manual/conditionalbuilds.html
ekohl
force-pushed
the
add-copr-chroot-conditionals
branch
from
d794ce3 to
4383b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RPM conditionals allow building with and without certain features.
This can be used to bootstrap builds, like foreman needing foreman-build
which is built from foreman.