Fix sleep analyzer loading only 1% of piezo data#38
Open
dallonby wants to merge 1 commit intothrowaway31265:mainfrom
Open
Fix sleep analyzer loading only 1% of piezo data#38dallonby wants to merge 1 commit intothrowaway31265:mainfrom
dallonby wants to merge 1 commit intothrowaway31265:mainfrom
Conversation
The CBOR file reading loop was exiting early when encountering records with empty data fields. This happened because: 1. Some RAW files contain records with `data: b''` (empty byte string) 2. When `cbor2.loads(b'')` is called, it raises `CBORDecodeEOF` 3. `CBORDecodeEOF` inherits from `EOFError` 4. The `except EOFError: break` handler catches this, exiting the loop This caused the sleep analyzer to load only ~250 records instead of ~46,000 per night, resulting in incomplete sleep detection. The fix simply skips records with empty data before attempting to decode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@dallonby is attempting to deploy a commit to the david's projects Team on Vercel. A member of the Team first needs to authorize it. |
dallonby
added a commit
to dallonby/free-sleep
that referenced
this pull request
Dec 26, 2025
The same fix from PR throwaway31265#38 (19ac510) needs to be applied to stream.py. Some RAW files contain records where 'data' is an empty byte string. Calling cbor2.loads(b'') raises CBORDecodeEOF (inherits from EOFError), which was caught by the EOFError handler and broke out of the read loop. This caused the stream processor to only capture ~4 piezo records per sleep session instead of continuous data, resulting in only 2-3 vitals records per night instead of hundreds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3 tasks
dallonby
added a commit
to dallonby/free-sleep
that referenced
this pull request
Dec 28, 2025
The same fix from PR throwaway31265#38 (19ac510) needs to be applied to stream.py. Some RAW files contain records where 'data' is an empty byte string. Calling cbor2.loads(b'') raises CBORDecodeEOF (inherits from EOFError), which was caught by the EOFError handler and broke out of the read loop. This caused the stream processor to only capture ~4 piezo records per sleep session instead of continuous data, resulting in only 2-3 vitals records per night instead of hundreds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Nice investigation! We hit the same issue in sleepypod-core and patched it in our TypeScript CBOR reader — the fix landed in sleepypod/core#178 (merged into dev). Our approach handles it at the byte-parsing level: Thanks for tracking this down 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
data: b''(empty byte string)cbor2.loads(b'')is called, it raisesCBORDecodeEOFCBORDecodeEOFinherits fromEOFErrorexcept EOFError: breakhandler catches this, exiting the loop prematurelyFix
Skip records with empty data before attempting to decode.
Test plan
🤖 Generated with Claude Code