Add regression tests for createDataPartition()#1383
Open
MichaelChirico wants to merge 5 commits intotopepo:masterfrom
Open
Add regression tests for createDataPartition()#1383MichaelChirico wants to merge 5 commits intotopepo:masterfrom
MichaelChirico wants to merge 5 commits intotopepo:masterfrom
Conversation
This was referenced May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created as a confidence booster for the refactor in #1382.
Note the added input validation for numeric
y-- currently,createDataPartition()will error fromquantile()when passed missing values. See also #1384.This started as a suite generated by Gemini -- I prompted it for a test suite, then cleaned up a few stale usage patterns, ran the tests and iterated until the HEAD behavior passes the suite. However, I did not find it very satisfactory -- it seems wary of the random nature of the output & unwililng to put some actually useful tests in place, despite the use of
local_seed(). So, I mostly stripped out all the crufty tests it wrote and replaced them withexpect_identical()tests of thecreateDataPartition()output.